Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNNE-1714:Fix/regression bugs #1117

Merged
merged 9 commits into from
Nov 2, 2023
Merged

GNNE-1714:Fix/regression bugs #1117

merged 9 commits into from
Nov 2, 2023

Conversation

uranus0515
Copy link
Contributor

1, Implement ConvTranspose to avoid OrtKi bugs;
2, Avoid null name caused by reference types;

@uranus0515 uranus0515 closed this Oct 31, 2023
@uranus0515 uranus0515 reopened this Oct 31, 2023
Copy link

github-actions bot commented Nov 1, 2023

Test Results

5 831 tests  ±0   5 831 ✔️ ±0   12m 0s ⏱️ +8s
       6 suites ±0          0 💤 ±0 
       6 files   ±0          0 ±0 

Results for commit 0abbc2b. ± Comparison against base commit 1073f35.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1073f35) 76.75% compared to head (0abbc2b) 76.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1117      +/-   ##
==========================================
+ Coverage   76.75%   76.77%   +0.02%     
==========================================
  Files         689      689              
  Lines       24357    24385      +28     
  Branches     3881     3891      +10     
==========================================
+ Hits        18695    18722      +27     
- Misses       5055     5056       +1     
  Partials      607      607              
Flag Coverage Δ
integration 40.56% <97.91%> (+0.06%) ⬆️
unit 68.63% <85.41%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/Nncase.Importer/TFLite/MatMul.cs 64.58% <100.00%> (-1.42%) ⬇️
src/Nncase.Evaluator/NN/Conv2DTranspose.cs 75.60% <97.67%> (+12.14%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@FusionBolt FusionBolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ToArray should be called outside the loop. Otherwise it will be very slow.

@uranus0515 uranus0515 merged commit 1300e76 into master Nov 2, 2023
@uranus0515 uranus0515 deleted the fix/regression_bugs branch November 2, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants