Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load kmodel from stream #982

Merged
merged 18 commits into from
Jul 11, 2023
Merged

Load kmodel from stream #982

merged 18 commits into from
Jul 11, 2023

Conversation

sunnycase
Copy link
Member

Support loading kmodel from stream to save memory usage.

@github-actions
Copy link

github-actions bot commented Jun 26, 2023

Test Results

5 472 tests  ±0   5 472 ✔️ ±0   19m 48s ⏱️ - 3m 15s
       5 suites ±0          0 💤 ±0 
       5 files   ±0          0 ±0 

Results for commit fa0adb2. ± Comparison against base commit 7d9ac5d.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.12 ⚠️

Comparison is base (1ff6eba) 80.48% compared to head (f38c2e6) 80.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #982      +/-   ##
==========================================
- Coverage   80.48%   80.37%   -0.12%     
==========================================
  Files         592      628      +36     
  Lines       18548    20932    +2384     
==========================================
+ Hits        14929    16824    +1895     
- Misses       3619     4108     +489     
Flag Coverage Δ
integration 45.64% <ø> (-1.10%) ⬇️
unit 71.89% <ø> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
....Modules.StackVM/CodeGen/StackVM/CodeGenUtility.cs 62.50% <ø> (ø)
...odules.StackVM/CodeGen/StackVM/CodeGenVisitor.g.cs 69.00% <ø> (+2.33%) ⬆️
....Modules.StackVM/CodeGen/StackVM/CodegenVisitor.cs 89.09% <ø> (-0.22%) ⬇️
....Modules.StackVM/CodeGen/StackVM/StackVMEmitter.cs 77.77% <ø> (+7.93%) ⬆️
...odules.StackVM/CodeGen/StackVM/StackVMEmitter.g.cs 98.23% <ø> (+53.63%) ⬆️
....StackVM/CodeGen/StackVM/StackVMFunctionBuilder.cs 88.46% <ø> (-9.32%) ⬇️
...StackVM/CodeGen/StackVM/StackVMLinkableFunction.cs 93.33% <ø> (ø)
...s.StackVM/CodeGen/StackVM/StackVMLinkableModule.cs 92.85% <ø> (ø)
...les.StackVM/CodeGen/StackVM/StackVMLinkedModule.cs 100.00% <ø> (ø)
...es.StackVM/CodeGen/StackVM/StackVMModuleBuilder.cs 100.00% <ø> (+33.33%) ⬆️
... and 4 more

... and 221 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@curioyang
Copy link
Member

RTT works fine.

Copy link
Member

@curioyang curioyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunnycase sunnycase merged commit a0880c5 into master Jul 11, 2023
@sunnycase sunnycase deleted the feature/load_kmodel_from_stream branch July 11, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants