Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug log softmax get nan or inf result #985

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

liuzm6217-jianan
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 29, 2023

Test Results

5 467 tests  ±0   5 467 ✔️ ±0   22m 47s ⏱️ -1s
       5 suites ±0          0 💤 ±0 
       5 files   ±0          0 ±0 

Results for commit e204890. ± Comparison against base commit 9da765a.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.36 🎉

Comparison is base (1ff6eba) 80.48% compared to head (e204890) 80.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #985      +/-   ##
==========================================
+ Coverage   80.48%   80.85%   +0.36%     
==========================================
  Files         592      626      +34     
  Lines       18548    20768    +2220     
==========================================
+ Hits        14929    16791    +1862     
- Misses       3619     3977     +358     
Flag Coverage Δ
integration 45.98% <ø> (-0.77%) ⬇️
unit 72.30% <ø> (+0.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
....Modules.StackVM/CodeGen/StackVM/CodeGenUtility.cs 62.50% <ø> (ø)
...odules.StackVM/CodeGen/StackVM/CodeGenVisitor.g.cs 69.00% <ø> (+2.33%) ⬆️
....Modules.StackVM/CodeGen/StackVM/CodegenVisitor.cs 89.09% <ø> (-0.22%) ⬇️
....Modules.StackVM/CodeGen/StackVM/StackVMEmitter.cs 77.77% <ø> (+7.93%) ⬆️
...odules.StackVM/CodeGen/StackVM/StackVMEmitter.g.cs 98.23% <ø> (+53.63%) ⬆️
....StackVM/CodeGen/StackVM/StackVMFunctionBuilder.cs 88.46% <ø> (-9.32%) ⬇️
...StackVM/CodeGen/StackVM/StackVMLinkableFunction.cs 93.33% <ø> (ø)
...s.StackVM/CodeGen/StackVM/StackVMLinkableModule.cs 92.85% <ø> (ø)
...les.StackVM/CodeGen/StackVM/StackVMLinkedModule.cs 100.00% <ø> (ø)
...es.StackVM/CodeGen/StackVM/StackVMModuleBuilder.cs 100.00% <ø> (+33.33%) ⬆️
... and 4 more

... and 219 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@liuzm6217-jianan liuzm6217-jianan merged commit d5e23bc into master Jun 30, 2023
@liuzm6217-jianan liuzm6217-jianan deleted the hotfix/log_softmax_get_nan_or_inf_result branch June 30, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants