Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move macros list to jgierer12/awesome-babel-macros #90

Merged
merged 3 commits into from
Nov 15, 2018
Merged

Move macros list to jgierer12/awesome-babel-macros #90

merged 3 commits into from
Nov 15, 2018

Conversation

jgierer12
Copy link
Contributor

What:

Add a link to my Awesome babel macros list to the Readme.

Admittedly, my list is currently more or less equivalent to the list of macros in your own docs. However, I plan to actively maintain my list and add any new macros and resources as I come across them.

Why:

I'm a big fan of macros, and thought they deserved their own Awesome list. Having a dedicated list instead of burying it in the docs will help with discoverability/SEO. Additionally, having my own repo will make it much easier for me to maintain the list.

@codecov
Copy link

codecov bot commented Nov 14, 2018

Codecov Report

Merging #90 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #90   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          80     80           
  Branches       19     19           
=====================================
  Hits           80     80

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3f9b1e...38ee290. Read the comment docs.

Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Maybe we can remove the macros.md file too and just reference your repo. Could you do that please?

@jgierer12 jgierer12 changed the title Link to jgierer12/awesome-babel-macros Move macros list to jgierer12/awesome-babel-macros Nov 15, 2018
@jgierer12
Copy link
Contributor Author

Sure, done in 7400421 👍

Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thank you!

@kentcdodds
Copy link
Owner

I'll merge this in a minute. Thanks again!

@kentcdodds
Copy link
Owner

Would you like to add yourself to the contributors table?

@jgierer12
Copy link
Contributor Author

Would you like to add yourself to the contributors table?

Yes, thank you 😃

@kentcdodds kentcdodds merged commit 86b3531 into kentcdodds:master Nov 15, 2018
@jgierer12 jgierer12 deleted the patch-1 branch November 15, 2018 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants