This repository has been archived by the owner on Jan 6, 2021. It is now read-only.
Dont change non path on win32 #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanReyLop
reviewed
Apr 13, 2017
src/variable.js
Outdated
| @@ -1,14 +1,26 @@ | |||
| import isWindows from 'is-windows' | |||
|
|
|||
| const pathLikeEnvVarWhitelist = ['PATH', 'NODE_PATH'].reduce( | |||
There was a problem hiding this comment.
This seems overly complicated. What about simply new Set(['PATH', 'NODE_PATH'])?
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 42 45 +3
=====================================
+ Hits 42 45 +3
Continue to review full report at Codecov.
|
kentcdodds
suggested changes
Apr 13, 2017
There was a problem hiding this comment.
Looks great other than that one comment from @DanReyLop. Also, would you like to add yourself to the contributors table?
kentcdodds
approved these changes
Apr 13, 2017
| "profile": "https://twitter.com/paulcbetts", | ||
| "contributions": [ | ||
| "bug", | ||
| "code" |
There was a problem hiding this comment.
Missed test. You can add it in another PR if you want :)
|
@kentcdodds Works for me! |
kentcdodds
pushed a commit
that referenced
this pull request
May 11, 2017
* Add a whitelist for variables to : => ; ify * Plumb the name through * Write some tests * Dox, linter fascism * Much better! * Contributors BREAKING CHANGES: We no longer swap `:` for `;` on windows for any variables other than `PATH` and `NODE_PATH`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #106