Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
The
items
parameter ofmatchSorter
as well as thekeys
option are being changed toReadonlyArray
from a plainArray
. This more closely represents the contract of the function, as it does not modify these arrays.Fixes #128.
Why:
Even though
matchSorter
does not modify its input array, it cannot be called with a value of typeReadonlyArray
:How:
The required changes are simple: The input types are changed to
ReadyonlyArray
. This is not a breaking change, asArray
is a subtype ofReadonlyArray
in typescript, so "normal arrays" can be passed in like before.Checklist: