feat(nested keys): add ability to pass in keypath for object value #2
Conversation
conorhastings
force-pushed
the
nested-key
branch
5 times, most recently
from
f4ec62f to
a8242dc
Compare
Current coverage is 100% (diff: 100%)@@ master #2 diff @@
===================================
Files 1 1
Lines 67 72 +5
Methods 0 0
Messages 0 0
Branches 0 0
===================================
+ Hits 67 72 +5
Misses 0 0
Partials 0 0
|
|
Oh, if you could keep that section in the roadmap and just replace the item with "ideas?" That'd be great. Also, would you like to add yourself to the contributors? Run |
conorhastings
force-pushed
the
nested-key
branch
from
a8242dc to
cf00c47
Compare
|
@kentcdodds updated. thanks! |
|
LGTM |
|
Thank you! I just added you as a collaborator to the project. Want to merge your own pull request? |
|
Whoops, I forgot to add a maintainers file for lgtm.co/ If you rebase master and push that should fix it |
This allows you to pass in keypaths instead of just single keys.
Makes things such as {keys: ['name.first']} possible.
closes kentcdodds#1
conorhastings
force-pushed
the
nested-key
branch
from
cf00c47 to
9e00020
Compare
|
@kentcdodds thanks for the adding me! I rebased but it still doesn't seem to be going through. Let me know if there's anything i could do |
|
|
|
👍 |
|
LGTM |
|
Hmmm... Looks like something's wrong with lgtm.co :-( Maybe next PR it'll work better. Could be a caching issue. Anyway, thanks! And welcome to the team! |
This allows you to pass in keypaths instead of just single keys.
Makes things such as {keys: ['name.first']} possible.
closes #1