Fixes issue with filtering with property values of number 0 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentcdodds
reviewed
May 6, 2018
src/index.js
Outdated
| @@ -387,7 +387,7 @@ function getItemValues(item, key) { | |||
| value = item[key] | |||
| } | |||
| // concat because `value` can be a string or an array | |||
| return value ? [].concat(value) : null | |||
| return value || value === 0 ? [].concat(value) : null | |||
There was a problem hiding this comment.
I'd rather change this to:
return value == null ? [].concat(value) : nullThat way we cover null and undefined and all other cases will be concatenate.
There was a problem hiding this comment.
Makes sense. Will change it.
kentcdodds
reviewed
May 7, 2018
|
Nope, validate script fails locally : |
|
Hmmm... Looks like your changes are not related to this. It's breaking for me locally without your changes. I'll look into it. |
|
I'm not sure what happened, but things were very out of date. I've updated everything and it should work now. |
|
Thanks a bunch! |
|
🎉 This PR is included in version 2.2.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
#46
The filter does not return data if the value of the key being filtered is the number 0
Why:
It is possible that the data may contain properties with values which are numbers (e.g. age) and these properties could have the value 0 as well. Hence, filtering on 0 should be possible.
How:
By adding an additional check to make sure the number 0 is not incorrectly rejected by the if statement.
Checklist: