chore(build): add rollup to bundle external deps #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decided to go with rollup so we could benefit from reducing closures created by webpack and also because I wanted to learn something new. I tested this and we should be able to add dependencies and import them with ES6 modules and benefit from treeshaking when possible, which is neat.
|
Do you got a second to give this a look @conorhastings? Thoughts? |
Current coverage is 100% (diff: 100%)@@ master #9 diff @@
===================================
Files 1 1
Lines 73 73
Methods 0 0
Messages 0 0
Branches 0 0
===================================
Hits 73 73
Misses 0 0
Partials 0 0
|
|
|
|
nice, LGTM. I've been meaning to try rollup as well, seems like it's going to be the way to go for libraries with apps staying in webpack land. |
|
Yeah, I agree. Though I'd love Webpack to get the same features so I can have one tool for both. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decided to go with rollup so we could benefit from reducing closures created by webpack and also because I wanted to learn something new.
I tested this and we should be able to add dependencies and import them with ES6 modules and benefit from treeshaking when possible, which is neat.