update keplergl-jupyter bindings #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lixun910
force-pushed
the
build-pypi-conda
branch
from
e84002a to
7f4a78a
Compare
|
@heshan0131 pull request is ready for review. Thanks! |
can you rebase your pr with master, it seems to contain the last PR on master once you rebased your pr with master, you need to do a force push to remote branch |
lixun910
force-pushed
the
build-pypi-conda
branch
2 times, most recently
from
9ecd861 to
8b41959
Compare
author Xun Li <[email protected]> 1628282154 -0700 committer Xun Li <[email protected]> 1628888305 -0700 parent d7afdd6 author Xun Li <[email protected]> 1628282154 -0700 committer Xun Li <[email protected]> 1628888276 -0700 parent d7afdd6 author Xun Li <[email protected]> 1628282154 -0700 committer Xun Li <[email protected]> 1628888217 -0700 Create build-publish-pypi.yml Add GitHub Actions to build and publish keplergl python package to PyPI Update build-publish-pypi.yml Add mapbox token secret fix artifact path fix condition to publish to pypi Update build-publish-pypi.yml fix path in upload-artifact and publish pypi Update build-publish-pypi.yml add Check KeplerGL Installation add Test Notebook DataFrame.ipynb Update build-publish-pypi.yml update test KeplerGL Update build-publish-pypi.yml The keplergl-jupyter widget needs to be updated for JupyterLab 3 keplergl#882 keplergl#1565 keplergl#1165 Update build-publish-pypi.yml add jupyter-packaging Update build-publish-pypi.yml add jupyter for jupyter labextension build Update build-publish-pypi.yml add jupyterlab Add support to Google colab keplergl#931 Update build-publish-pypi.yml fix path in upload-artifact and publish pypi Signed-off-by: Xun Li <[email protected]> Update build-publish-pypi.yml Signed-off-by: Xun Li <[email protected]> The keplergl-jupyter widget needs to be updated for JupyterLab 3 keplergl#882 keplergl#1565 keplergl#1165 Signed-off-by: Xun Li <[email protected]> Update build-publish-pypi.yml add jupyterlab Signed-off-by: Xun Li <[email protected]> Add support to Google colab keplergl#931 Signed-off-by: Xun Li <[email protected]> allow height option to work in google colab Signed-off-by: Xun Li <[email protected]>
lixun910
force-pushed
the
build-pypi-conda
branch
from
8b41959 to
26acd67
Compare
|
Got it. Thanks, @heshan0131 Just rebase my pr with master. |
heshan0131
reviewed
Aug 19, 2021
|
Can you add to https://github.com/keplergl/kepler.gl/blob/master/docs/keplergl-jupyter/README.md To describe:
|
1. add "Installation -- Using conda" 2. add notes for install keplergl for jupyterlab3 3. add section to setup local dev env for jupyter notebook and jupyterlab 4. add section to use KeplerGL in google colab 5. add comments for show() function Signed-off-by: Xun Li <[email protected]>
lixun910
force-pushed
the
build-pypi-conda
branch
from
1570483 to
f438ccd
Compare
heshan0131
reviewed
Aug 19, 2021
heshan0131
reviewed
Aug 19, 2021
Signed-off-by: Xun Li <[email protected]>
lixun910
force-pushed
the
build-pypi-conda
branch
from
46e84f3 to
ab0b6f7
Compare
Signed-off-by: Xun Li <[email protected]>
lixun910
force-pushed
the
build-pypi-conda
branch
from
879f407 to
5353437
Compare
….4, therefore node version >= 12.0.0 should be expected. update formats. Signed-off-by: Xun Li <[email protected]>
Signed-off-by: Xun Li <[email protected]>
heshan0131
reviewed
Aug 29, 2021
| @@ -0,0 +1,77 @@ | |||
| name: Build KeplerGL Python and NPM Packages | |||
|
|
|||
| on: push | |||
There was a problem hiding this comment.
should this be on:push or on:release?
There was a problem hiding this comment.
I think it should be “on:push”, which means this action can be used to build, check and test keplergl python package on push with changes. For release and publish, there is a step: “-name: Check Release Tag”.
There was a problem hiding this comment.
Also, see the updated steps in “RELEASE.md” : https://github.com/lixun910/kepler.gl/blob/build-pypi-conda/bindings/kepler.gl-jupyter/RELEASE.md
|
@heshan0131 When will this be released into a new version for |
|
Any update on when will this be released? Latest versions on pypi and conda-forge are still 0.3.0 |
phi-line
pushed a commit
to phi-line/kepler.gl
that referenced
this pull request
Oct 21, 2022
… conda-forge (keplergl#1572) 1. Upgrade keplergl-jupyter widget for JupyterLab 3 2. Add build script to build keplergl-jupyter for jupyterlab separately using @jupyter/builder 3. Upgrade build script setup.py using jupyter_packaging library 4. Add support to Google colab (no interaction with widget because of lacking colab support). New function show() was proposed 5. Add GitHub Actions “build-publish-pypi.yml” to build, test and publish (when tag release) keplergl python package to PyPI: 6. Add condo-forge/keplergl-feedstock repo: https://github.com/lixun910/staged-recipes/tree/keplergl-feedstock (transfer to keplergl org later) Signed-off-by: Xun Li <[email protected]> Signed-off-by: kishan <[email protected]>
phi-line
pushed a commit
to phi-line/kepler.gl
that referenced
this pull request
Oct 21, 2022
… conda-forge (keplergl#1572) 1. Upgrade keplergl-jupyter widget for JupyterLab 3 2. Add build script to build keplergl-jupyter for jupyterlab separately using @jupyter/builder 3. Upgrade build script setup.py using jupyter_packaging library 4. Add support to Google colab (no interaction with widget because of lacking colab support). New function show() was proposed 5. Add GitHub Actions “build-publish-pypi.yml” to build, test and publish (when tag release) keplergl python package to PyPI: 6. Add condo-forge/keplergl-feedstock repo: https://github.com/lixun910/staged-recipes/tree/keplergl-feedstock (transfer to keplergl org later) Signed-off-by: Xun Li <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup.pyusing jupyter_packaging libraryshow()was proposed:Others
Related issues:
#646
#1565 #882 #1565 #1165 #931