Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] vector tile layer #2839

Merged
merged 34 commits into from
Dec 22, 2024
Merged

[feat] vector tile layer #2839

merged 34 commits into from
Dec 22, 2024

Conversation

igorDykhta
Copy link
Collaborator

@igorDykhta igorDykhta commented Dec 16, 2024

This PR adds Vector Tile layer to Kepler with support initial support of mapbox vector tiles and remote .pmtiles (with mimeType application/vnd.mapbox-vector-tile)

  • lint
  • fix dynamic domains
  • cpu filter filter for string domains > disabled, no easy solution
  • dataset info - 0 rows change to Vector Tile
  • pmtiles support in Tile
  • zoom to bounds
  • export data - 0 rows?
  • export map to json & import
  • export map to html & open (release + umd update required)
  • save to Storage / load from storage
  • share map url and load
  • highlight hovered object
  • move types to /types module (prevent circular deps)
  • add tileset modal - fix UI
  • JSON component
  • fix tests
  • add tests
  • example?
  • collect attribution from datasets
  • docs - layers - vector tiles

Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for keplergl2 ready!

Name Link
🔨 Latest commit 813b5b7
🔍 Latest deploy log https://app.netlify.com/sites/keplergl2/deploys/67683389a690ae0008daa8aa
😎 Deploy Preview https://deploy-preview-2839--keplergl2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to review but it is way too big. I guess this is a result of the upstreaming process. Otherwise this could have been broken into some enabling code as separate initial PRs.

docs/user-guides/c-types-of-layers/README.md Outdated Show resolved Hide resolved
examples/demo-app/src/app.tsx Show resolved Hide resolved
src/common-utils/src/data.ts Outdated Show resolved Hide resolved
src/common-utils/src/url.ts Show resolved Hide resolved
src/components/src/hooks/use-fetch-vector-tile-metadata.ts Outdated Show resolved Hide resolved
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
@igorDykhta igorDykhta marked this pull request as ready for review December 22, 2024 16:17
@igorDykhta igorDykhta merged commit e106c19 into master Dec 22, 2024
12 checks passed
@igorDykhta igorDykhta deleted the igr/vector-tiles branch December 22, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants