selftests/bpf: correct the check of join cgroup

Use ASSERT_OK_FD to check the return value of join cgroup, or else this test will pass even if the fd < 0. ASSERT_OK_FD can print the error message to the console. Link: https://lore.kernel.org/all/[email protected]/ Suggested-by: Martin KaFai Lau <[email protected]> Signed-off-by: Jason Xing <[email protected]>
kernel-patches · Feb 4, 2025 · 0827f7a · 0827f7a
1 parent ab4839c
commit 0827f7a
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/tools/testing/selftests/bpf/prog_tests/setget_sockopt.c b/tools/testing/selftests/bpf/prog_tests/setget_sockopt.c
@@ -202,7 +202,7 @@ static void test_nonstandard_opt(int family)
 void test_setget_sockopt(void)
 {
 	cg_fd = test__join_cgroup(CG_NAME);
-	if (cg_fd < 0)
+	if (!ASSERT_OK_FD(cg_fd, "join cgroup"))
 		return;
 
 	if (create_netns())