-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support I/O schema v4.3 #474
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9993279
to
bf159d8
Compare
537d25d
to
1462ebe
Compare
1462ebe
to
7b2797c
Compare
7b2797c
to
cd37bd5
Compare
cd37bd5
to
ef559ff
Compare
ef559ff
to
dd81d3a
Compare
Upgrade the Python requirement to v3.9. Upgrade the Cloud Function runtime as well, exporting the GCP_PROJECT variable explicitly, as the new runtime doesn't have it.
Switch from the deprecated Container Registry, used by default for Cloud Functions 1st gen, to the new Artifact Registry. See https://cloud.google.com/artifact-registry/docs/transition/transition-from-gcr
dd81d3a
to
34301be
Compare
34301be
to
3c195c3
Compare
3c195c3
to
c181ff0
Compare
d9ee60b
to
4b36551
Compare
The mux driver lists the schemas starting from the current one if the databases are initialized, and all schemas, if not, but it wasn't resetting the schema list after cleaning up the databases. Fix that.
Rename the bigquery schema's `KEY_MAP` field to `KEYS_MAP` as each value in the dictionary can contain multiple keys.
Stop pre-generating a column list for SQL statements in kcidb.db.sql.schema, and generate it on demand instead, to prepare for adding column filtering.
Simplify the primary key list handling in kcidb.db.sql.schema. Also stop comparing original and database column names when generating the array, as that would break if the names needed to be quoted or contained a dot.
Instead of storing maps of table names and schema objects, store the maps of table names and schema constructor args, so they could be modified when inheriting, in both kcidb.db.sql-based drivers - PostgreSQL and SQLite. This prepares for addition of fields in derived schemas.
Support retrieving the current time from the database server, so it's easier to test the purging functionality coming later.
43917c8
to
fe539ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.