Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix password secret deployment #490

Closed
wants to merge 3 commits into from
Closed

Fix password secret deployment #490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
476130d
cloud: Remove unused local for SMTP secret
spbnick Jan 17, 2024
aea168d
cloud: Disable PostgreSQL auto storage increase
spbnick Jan 17, 2024
3cccede
cloud: Fix password secret deployment
spbnick Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cloud
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ function execute_command() {
declare -r updated_topic="${prefix}updated"
declare -r updated_debug_subscription="${prefix}updated_debug"
declare -r spool_collection_path="${prefix}notifications"
declare -r smtp_password_secret="kcidb_smtp_password"

declare -r psql_connection=$(
echo -n "${project}:"
Expand Down
2 changes: 1 addition & 1 deletion kcidb/cloud/password.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ function password_deploy_secret() {
# Get and cache the password in the current shell first
password_get "$name" > /dev/null
# Deploy the cached password
password_get "$name" | secret_deploy "$project" "$name"
password_get "$name" | secret_deploy "$project" "$secret"
fi
done
}
Expand Down
1 change: 1 addition & 0 deletions kcidb/cloud/psql.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ function psql_instance_deploy() {
--region="$PSQL_INSTANCE_REGION" \
--tier="$PSQL_INSTANCE_TIER" \
--assign-ip \
--no-storage-auto-increase \
--database-flags=cloudsql.iam_authentication=on \
--root-password="$(password_get psql_superuser)" \
--database-version=POSTGRES_14
Expand Down