Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy connecting lab documentation #338

Closed
JenySadadia opened this issue Apr 26, 2024 · 8 comments · Fixed by #365
Closed

Deploy connecting lab documentation #338

JenySadadia opened this issue Apr 26, 2024 · 8 comments · Fixed by #365
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@JenySadadia
Copy link
Contributor

Initial documentation for connecting LAVA lab in the pipeline is added here.

Deploy it on kernelci.org/docs.

@JenySadadia JenySadadia added the documentation Improvements or additions to documentation label Apr 26, 2024
@JenySadadia JenySadadia self-assigned this May 22, 2024
@JenySadadia
Copy link
Contributor Author

I think we should move this doc to https://github.com/kernelci/kernelci-api/tree/main/doc to centralize all the API & Pipeline documentation under one repository.
What do you think? @pawiecz @nuclearcat

@pawiecz
Copy link

pawiecz commented May 22, 2024

I understand the reason to keep all the docs in a single place. I also get that keeping several submodules in the -project is not always convenient. I'd still keep the pipeline configuration docs as close as possible to the relevant files, though (leaving kernelci/kernelci-pipeline#592 as it is).

To have the docs from kernelci/kernelci-pipeline#592 published there would be a need for another submodule. This, however, would also pull the doc/result-summary-CHANGELOG - is it still needed there?

There's one more thing that needs to be discussed but I'm not 100% sure what would be the best way to proceed with it: connecting labs also involves some sysadmin work/secret management. I believe having a public process for that would increase transparency - do you think this could be shared while still maintaining all necessary information secure?

@JenySadadia
Copy link
Contributor Author

Okay. Your points make sense.
We can consider adding a submodule to kernelci-project.
But atm we included all the pipeline related documentation to kernelci-api repo. Should we need to move it to the pipeline repo as well?

@pawiecz
Copy link

pawiecz commented May 22, 2024

Out of all the docs stored in the kernelci-api repo:

kernelci-api$ tree doc
doc
├── api-details.md
├── design.md
├── developer-documentation.md
├── early-access.md
├── _index.md
├── local-instance.md
└── pipeline-details.md

I'd move only developer-documentation.md (after the submodule is enabled) as that guide mostly covers changes to the config/pipeline.yaml file from -pipeline repository.

We'd still be able to have it easily accessible (as the rendered content on Hugo) and point external labs admins/other contributors there.

@JenySadadia
Copy link
Contributor Author

We'd also need to move pipeline-details page as it describes pipeline services. local-instance page also has a pipeline instance setup documentation.

@pawiecz
Copy link

pawiecz commented May 22, 2024

Agreed 100% on pipeline-details. I'm a bit torn on local-instance as it covers setup of both components and still uses API as the main "user interface". On top of this, I'm afraid that splitting the guide could bring more confusion than clarity.

@JenySadadia
Copy link
Contributor Author

Yes, I agree. Then, we need to leave it as-is and just move pipeline-details page.

@JenySadadia
Copy link
Contributor Author

All the related PRs have been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants