Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kernelci-pipeline submodule #365

Merged
merged 2 commits into from
May 29, 2024

Conversation

JenySadadia
Copy link
Contributor

Closes #338

Add kernelci-pipeline as a submodule to be able to include its documentation to kernelci.org/external.

Add `kernelci-pipeline` as a submodule to be able
to include its documentation to `kernelci.org/external`.

Signed-off-by: Jeny Sadadia <[email protected]>
@JenySadadia JenySadadia force-pushed the kci-pipeline-submodule branch 4 times, most recently from 3ef694d to 8350e3f Compare May 29, 2024 07:06
@JenySadadia JenySadadia marked this pull request as ready for review May 29, 2024 09:09
@JenySadadia JenySadadia requested a review from pawiecz May 29, 2024 09:09
@JenySadadia
Copy link
Contributor Author

Tested OK locally in conjunction with the below PRs:

Screenshot from 2024-05-29 14-38-34

@JenySadadia JenySadadia force-pushed the kci-pipeline-submodule branch from 8350e3f to cf57881 Compare May 29, 2024 09:21
Add a new directory to accommodate documentation from
`kernelci-api` and `kernelci-pipeline` repositories.
Add symlink for pipeline doc inside `api_pipeline`
directory. Move symlink for api doc to `api_pipeline`.

Signed-off-by: Jeny Sadadia <[email protected]>
@JenySadadia JenySadadia force-pushed the kci-pipeline-submodule branch from cf57881 to ee5b4aa Compare May 29, 2024 13:01
Copy link

@pawiecz pawiecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I'd merge it but I lack permissions)

@nuclearcat nuclearcat merged commit 67f682c into kernelci:main May 29, 2024
1 check passed
@JenySadadia
Copy link
Contributor Author

I am not able to verify if the internal link works.
I'll merge this after it's verified.
@nuclearcat When will we be able to deploy this on staging? The local setup is kind of annoying me now.

@JenySadadia
Copy link
Contributor Author

Opps, please don't merge kernelci/kernelci-api#533.

@JenySadadia JenySadadia deleted the kci-pipeline-submodule branch May 29, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy connecting lab documentation
3 participants