-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sorting arrays #39
Open
nathanschwarz
wants to merge
10
commits into
kesla:master
Choose a base branch
from
nathanschwarz:sortingArrays
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Sorting arrays #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Cool |
@kesla any chance this will be merged soon? It's already a second take of an earlier contribution and now has a bunch of conflicts again. |
@kesla @kingthorin has a very good question, one that makes me wonder if #12 was close with valid resolution. |
@kesla, this is exactly the feature I was missing, works well for me, any reasons why this is not merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the possibility to sort arrays with the --key option.
I added new tests under
tests/overwrite.js
The option uses a MongoDB like string formating for the key
$
for arrays and.
for properities.It enables to sort arrays in ascending or descending order (even nested in objects or arrays).
You can sort plain arrays or arrays of object by a specific properity.