improve clarity of upper case characters and code reuse #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendmorris
force-pushed
the
improvement
branch
from
a056018 to
d3fe16a
Compare
blake2573
approved these changes
Nov 26, 2024
Samuel-BlankAmber
suggested changes
Nov 27, 2024
| export default "J"; | ||
| /** | ||
| * @link https://en.wikipedia.org/wiki/J | ||
| * I bet you didn't read through all of these |
There was a problem hiding this comment.
Suggested change
| * I bet you didn't read through all of these | |
| * I bet you did not read through all of these |
As this is in the documentation for the uppercase character J, I suspect many individuals reading this will not be familiar with advanced concepts such as Punctuation and Apostrophes. To ensure the documentation remains readable to beginners of the alphabet, I would encourage you to remove this use of an Apostrophe.
|
Hi, do we have an ETA on when this is getting merged? My team would greatly benefit from the superior DX provided by this PR and are eagerly awaiting its merge. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upper case letters can be derived from the lower case ones with only a minor runtime cost. Also added some helpful documentation for people unfamiliar with the concept of letters.
Context: https://twitter.com/bendmorris/status/1438369582125699072