Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide taskrun.iteration in ForEach task #4842

Closed
johnsturgeon opened this issue Sep 6, 2024 · 3 comments · Fixed by #6636
Closed

Provide taskrun.iteration in ForEach task #4842

johnsturgeon opened this issue Sep 6, 2024 · 3 comments · Fixed by #6636
Assignees
@loicmathieu
Labels
enhancement New feature or request kind/quick-win Seems to be quick to do

Comments

@johnsturgeon
Copy link

Feature description

I'm writing a flow that loops over a list of values using EachSequential and sets a KV Pair. I would like to name the key start_time_{index} where index would represent the loop counter / index.
@johnsturgeon johnsturgeon added the enhancement New feature or request label Sep 6, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Issues Sep 6, 2024
@Ben8t Ben8t added the kind/quick-win Seems to be quick to do label Sep 6, 2024
@Ben8t Ben8t changed the title Provide index or loopcount in ForEach or EachSequential Provide index in ForEach task Sep 6, 2024
@Ben8t Ben8t changed the title Provide index in ForEach task Provide iteration in ForEach task Sep 6, 2024
@Ben8t
Copy link
Member

Ben8t commented Sep 6, 2024

ForEachItem already have taskrun.iteration

We should add it to ForEach, EachSequential, and EachParallel

@Ben8t Ben8t changed the title Provide iteration in ForEach task Provide taskrun.iteration in ForEach task Sep 6, 2024
@pranavmugatkar
Copy link

pranavmugatkar commented Sep 29, 2024 •
edited
Loading

Hello Mam @anna-gellar, I am interested in contributing to this issue. I would like to implement the taskrun.iteration in the Given classes. Could you please confirm if I can proceed with this? Any guidance or specific requirements would be greatly appreciated. Thank you!

@tchiotludo tchiotludo added good first issue Great issue for new contributors and removed kind/good-first-issue labels Oct 1, 2024
@anna-geller
Copy link
Member

@pranavmugatkar feel free to take it 👍 just a note -- it will only be needed on ForEach because EachSequential and EachParallel are deprecated.

@loicmathieu loicmathieu removed the good first issue Great issue for new contributors label Dec 6, 2024
@loicmathieu loicmathieu self-assigned this Jan 3, 2025
@loicmathieu loicmathieu mentioned this issue Jan 3, 2025
Merged
@github-project-automation github-project-automation bot moved this from Backlog to Done in Issues Jan 3, 2025
anna-geller added a commit to kestra-io/docs that referenced this issue Jan 6, 2025
@anna-geller
docs for kestra-io/kestra#4842
1080ea2
Skraye pushed a commit to kestra-io/docs that referenced this issue Jan 24, 2025
@anna-geller @Skraye
docs for kestra-io/kestra#4842
d14a1e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@loicmathieu loicmathieu

Labels
enhancement New feature or request kind/quick-win Seems to be quick to do
Projects
Issues
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(core): add taskrun.iteration inside Pebble variables kestra-io/kestra
6 participants
@loicmathieu @tchiotludo @johnsturgeon @Ben8t @anna-geller @pranavmugatkar