fix(runner): compute CPU & memory allocations properly

kestra-io · Apr 16, 2024 · eaedbed · eaedbed
1 parent dc213a1
commit eaedbed
Showing 1 changed file with 14 additions and 2 deletions.
diff --git a/src/main/java/io/kestra/plugin/aws/runner/AwsBatchTaskRunner.java b/src/main/java/io/kestra/plugin/aws/runner/AwsBatchTaskRunner.java
@@ -368,8 +368,20 @@ public RunnerResult run(RunContext runContext, TaskCommands taskCommands, List<S
             );
         }
 
-        int sideContainersMemoryAllocations = hasS3Bucket ? baseSideContainerMemory * 2 : 0;
-        float sideContainersCpuAllocations = hasS3Bucket ? baseSideContainerCpu * 2 : 0;
+        int sideContainersAmount = 0;
+        if (outputDirectoryEnabled) {
+            sideContainersAmount = 2;
+        } else {
+            if (hasFilesToUpload) {
+                sideContainersAmount++;
+            }
+
+            if (hasFilesToDownload) {
+                sideContainersAmount++;
+            }
+        }
+        int sideContainersMemoryAllocations = baseSideContainerMemory * sideContainersAmount;
+        float sideContainersCpuAllocations = baseSideContainerCpu * sideContainersAmount;
 
         boolean needsOutputFilesContainer = hasFilesToDownload || outputDirectoryEnabled;
         TaskContainerProperties.Builder mainContainerBuilder = withResources(