Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MotherDuck support to the DuckDB plugin #143

Closed
anna-geller opened this issue Jul 16, 2023 · 1 comment · Fixed by #144
Closed

Add MotherDuck support to the DuckDB plugin #143

anna-geller opened this issue Jul 16, 2023 · 1 comment · Fixed by #144
Assignees
Labels
enhancement New feature or request

Comments

@anna-geller
Copy link
Member

anna-geller commented Jul 16, 2023

Feature description

MotherDuck should work out of the box based on the existing JDBC driver for DuckDB: https://motherduck.com/docs/integrations/jdbc-driver

image

But I can't connect, even when explicitly setting the token in the JDBC URL

id: md
namespace: dev
tasks:
  - id: md
    type: io.kestra.plugin.jdbc.duckdb.Query
    sql: |
      SELECT passenger_count, avg(total_amount) as avg_fare
      FROM sample_data.nyc.yellow_cab_nyc_2022_11
      GROUP BY passenger_count
      ORDER by passenger_count;
    store: true

taskDefaults:
  - type: io.kestra.plugin.jdbc.duckdb.Query
    values:
      url: "jdbc:duckdb:md:my_db"
      timeZoneId: Europe/Berlin

A dedicated plugin with the MotherDuck logo and an easier way to pass the MOTHERDUCK_TOKEN from a secret would be quite useful

The JDBC driver from here works well in my local IDE with both DuckDB and MotherDuck https://central.sonatype.com/artifact/org.duckdb/duckdb_jdbc/0.8.1/versions

@anna-geller anna-geller added the enhancement New feature or request label Jul 16, 2023
@anna-geller anna-geller changed the title Add MotherDuck support Add MotherDuck support to the DuckDB plugin Jul 16, 2023
@github-project-automation github-project-automation bot moved this to Backlog in All issues Jul 17, 2023
@loicmathieu loicmathieu self-assigned this Jul 17, 2023
@loicmathieu
Copy link
Member

DuckDB plugin is 60MB so I prefere that we make it works for both local DB and MotherDuck.
Currently, it hadcodes a JDBC URL with a local database that's why it didn't work on MotherDuck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants