fix: allow setting the JDBC URL for MotherDuck #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anna-geller
reviewed
Jul 17, 2023
plugin-jdbc-duckdb/src/main/java/io/kestra/plugin/jdbc/duckdb/Query.java
Outdated
Show resolved
Hide resolved
…Query.java Co-authored-by: Anna Geller <[email protected]>
brian-mulier-p
approved these changes
Jul 18, 2023
Comment on lines
+121
to
+122
| this.databaseFile = runContext.tempFile(); | ||
| Files.delete(this.databaseFile); |
There was a problem hiding this comment.
Why do we create a tempFile to delete it right afterwards (I know it was already there before but trying to understand)
There was a problem hiding this comment.
No idea, I think it's here to be sure that the file didn't exist as DuckDB will create it.
There was a problem hiding this comment.
duckdb expect to have an empty file for it's database, so this ugly method is only to have a temporary file path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #143