-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Db2 plugin #260
Db2 plugin #260
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
@iNikitaGricenko tests didn't pass, can yu have a look? |
Yes, seems like database doesn't have time to initialize before test runs |
You can either configure a readiness check on the docker compose or add a little Thread.sleep(1000) so the test start later (ugly but quick) |
seems like it doesn't wait for healthcheck, so i'm adding thread.sleep to see if this help, to make sure that issue with database initialization (as it take too long for it to initialize) |
… Increased time to wait, changed port
… Bring back container volume, as there is stores databases
…ly manual execution)
What changes are being made and why?
Implemented DB2 plugin (Which using db2 jdbc driver)
How the changes have been QAed?
Setup Instructions