Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Db2 plugin #260

Merged
merged 27 commits into from
Mar 28, 2024
Merged

Db2 plugin #260

merged 27 commits into from
Mar 28, 2024

Conversation

iNikitaGricenko
Copy link
Contributor

What changes are being made and why?

Implemented DB2 plugin (Which using db2 jdbc driver)

How the changes have been QAed?

id: read_db2
namespace: io.kestra.jdbc.db2

tasks:
  - id: read
    type: io.kestra.plugin.jdbc.db2.Query
    url: jdbc:db2://localhost:50000/testdb
    username: db2inst1
    password: password
    sql: select * from db2_types
    fetchOne: true
  - id: flow-id
    type: io.kestra.core.tasks.debugs.Return
    format: "{{outputs.update.row}}"

Setup Instructions

  • Setup docker from docker-compose-ci.yml file
  • Run test

Copy link
Member

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@loicmathieu
Copy link
Member

@iNikitaGricenko tests didn't pass, can yu have a look?

@iNikitaGricenko
Copy link
Contributor Author

Yes, seems like database doesn't have time to initialize before test runs

@loicmathieu
Copy link
Member

Yes, seems like database doesn't have time to initialize before test runs

You can either configure a readiness check on the docker compose or add a little Thread.sleep(1000) so the test start later (ugly but quick)

@iNikitaGricenko
Copy link
Contributor Author

seems like it doesn't wait for healthcheck, so i'm adding thread.sleep to see if this help, to make sure that issue with database initialization (as it take too long for it to initialize)

@loicmathieu loicmathieu merged commit d163769 into kestra-io:master Mar 28, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants