-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved the Batch tasks to not require an explicit columns specification #358
Conversation
…retrieved columns names for insert
plugin-jdbc/src/main/java/io/kestra/plugin/jdbc/AbstractJdbcBatch.java
Outdated
Show resolved
Hide resolved
plugin-jdbc/src/main/java/io/kestra/plugin/jdbc/AbstractJdbcBatch.java
Outdated
Show resolved
Hide resolved
plugin-jdbc-clickhouse/src/test/java/io/kestra/plugin/jdbc/clickhouse/ClickHouseTest.java
Outdated
Show resolved
Hide resolved
…rt. Added test to ClickHouseTest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
@iNikitaGricenko Postgres tests are failing, can you have a look? |
@iNikitaGricenko Vectorwize tests also fail, can you have a look? |
@loicmathieu Could you help me with this one, please (Provide exceptions details or something)? As i didn't manage to download Actian Vector (Vectorwize)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just saw that Batch Vectorwise tests are disabled, I disable the two you added, CI should pass now (except Rockset but it's expected)
plugin-jdbc-vectorwise/src/test/java/io/kestra/plugin/jdbc/vectorwise/BatchTest.java
Show resolved
Hide resolved
plugin-jdbc-vectorwise/src/test/java/io/kestra/plugin/jdbc/vectorwise/BatchTest.java
Show resolved
Hide resolved
…torwise/BatchTest.java
…torwise/BatchTest.java
What changes are being made and why?
How the changes have been QAed?