Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the Batch tasks to not require an explicit columns specification #358

Merged
merged 5 commits into from
Aug 22, 2024

Conversation

iNikitaGricenko
Copy link
Contributor

What changes are being made and why?


How the changes have been QAed?

tasks:
  - id: query
    type: io.kestra.plugin.jdbc.mysql.Query
    url: jdbc:mysql://127.0.0.1:3306/
    username: mysql_user
    password: mysql_passwd
    sql: |
      SELECT *
      FROM xref
      LIMIT 1500;
    store: true
  - id: update
    type: io.kestra.plugin.jdbc.mysql.Batch
    from: "{{ outputs.query.uri }}"
    url: jdbc:mysql://127.0.0.1:3306/
    username: mysql_user
    password: mysql_passwd
    table: xref

Copy link
Member

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@loicmathieu
Copy link
Member

@iNikitaGricenko Postgres tests are failing, can you have a look?

@loicmathieu
Copy link
Member

@iNikitaGricenko Vectorwize tests also fail, can you have a look?

@iNikitaGricenko
Copy link
Contributor Author

@loicmathieu Could you help me with this one, please (Provide exceptions details or something)? As i didn't manage to download Actian Vector (Vectorwize)?

Copy link
Member

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw that Batch Vectorwise tests are disabled, I disable the two you added, CI should pass now (except Rockset but it's expected)

@loicmathieu loicmathieu merged commit f09c4ca into kestra-io:master Aug 22, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants