generated from kestra-io/plugin-template
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented CLI task for ClickHouse #370
Merged
Merged
+158
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading status checks…
…retrieved columns names for insert
Loading status checks…
…rt. Added test to ClickHouseTest
Loading status checks…
Loading status checks…
…torwise/BatchTest.java
Loading status checks…
…torwise/BatchTest.java
loicmathieu
requested changes
Aug 30, 2024
plugin-jdbc-clickhouse/src/main/java/io/kestra/plugin/jdbc/clickhouse/cli/ClickHouseCLI.java
Outdated
Show resolved
Hide resolved
plugin-jdbc-clickhouse/src/main/java/io/kestra/plugin/jdbc/clickhouse/cli/ClickHouseCLI.java
Outdated
Show resolved
Hide resolved
plugin-jdbc-clickhouse/src/main/java/io/kestra/plugin/jdbc/clickhouse/cli/ClickHouseCLI.java
Outdated
Show resolved
Hide resolved
plugin-jdbc-clickhouse/src/main/java/io/kestra/plugin/jdbc/clickhouse/cli/ClickHouseCLI.java
Outdated
Show resolved
Hide resolved
plugin-jdbc-clickhouse/src/main/java/io/kestra/plugin/jdbc/clickhouse/cli/ClickHouseCLI.java
Outdated
Show resolved
Hide resolved
loicmathieu
reviewed
Aug 30, 2024
loicmathieu
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are being made and why?
How the changes have been QAed?