Merge pull request #168 from shrutimantri/correct-twilio-execution

fix(examples): add the required accountSID and authToken in Twilio tasks
kestra-io · Oct 11, 2024 · dffd675 · dffd675
2 parents 8581b2b + 42706a4
commit dffd675
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/main/java/io/kestra/plugin/notifications/twilio/TwilioAlert.java b/src/main/java/io/kestra/plugin/notifications/twilio/TwilioAlert.java
@@ -47,7 +47,9 @@
                 errors:
                   - id: alert_on_failure
                     type: io.kestra.plugin.notifications.twilio.TwilioAlert
-                    url: "{{ secret('TWILIO_ALERT') }}" # https://notify.twilio.com/v1/Services/ISXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX/Notifications
+                    url: "{{ secret('TWILIO_NOTIFICATION_URL') }}" # https://notify.twilio.com/v1/Services/ISXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX/Notifications
+                    accountSID: "{{ secret('TWILIO_ACCOUNT_SID') }}"
+                    authToken: "{{ secret('TWILIO_AUTH_TOKEN') }}"
                     payload: |
                       {
                         "identity": "0000001"
@@ -64,7 +66,9 @@
                 tasks:
                   - id: send_twilio_message
                     type: io.kestra.plugin.notifications.twilio.TwilioAlert
-                    url: "{{ secret('TWILIO_ALERT') }}"
+                    url: "{{ secret('TWILIO_NOTIFICATION_URL') }}"
+                    accountSID: "{{ secret('TWILIO_ACCOUNT_SID') }}"
+                    authToken: "{{ secret('TWILIO_AUTH_TOKEN') }}"
                     payload: |
                       {
                         "identity": "0000001"

diff --git a/src/main/java/io/kestra/plugin/notifications/twilio/TwilioExecution.java b/src/main/java/io/kestra/plugin/notifications/twilio/TwilioExecution.java
@@ -34,7 +34,9 @@
                 tasks:
                   - id: send_alert
                     type: io.kestra.plugin.notifications.twilio.TwilioExecution
-                    url: "{{ secret('TWILIO_ALERT') }}" # format: https://notify.twilio.com/v1/Services/ISXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX/Notifications
+                    url: "{{ secret('TWILIO_NOTIFICATION_URL') }}" # format: https://notify.twilio.com/v1/Services/ISXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX/Notifications
+                    accountSID: "{{ secret('TWILIO_ACCOUNT_SID') }}"
+                    authToken: "{{ secret('TWILIO_AUTH_TOKEN') }}"
                     identity: 0000001
                     executionId: "{{trigger.executionId}}"