PoC async fn as a Handler #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
|
Just closing some old PRs. Nothing to see here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PoC that we gotham-rs#370 (comment) can allow
async fnto implHandlerif we want to.It's not the cleanest code. Sorry.
Hopefully it's readable enough to get the idea across.
Unfortunately, if we
impl IntoHandlerFuture for F where F: SomeTraitthen we cannot alsoimpl impl IntoHandlerFuture for (State, T)(E0119), so I had to delete that impl. The only reason that we could get away with the previous pair of impls is that(State, T)andBox<HandlerFuture>are both structs, so the compiler can guarantee that it will always be able to disambiguate the two.If we want to support the convenience
(State, T)return type, we might be able to do this with a new.to_simple()function in the router builder. We might even be able to add a.to_compat()function, which takes an old-style future.