path to fix "build now" problems

[mvk]

NOTE: this is 1 of 2 issues causing these bugs #86 and #73

A regex used in several isJob*() methods does: return path.match(/^\/job\/.*?\//) !== null;, or similar.
This regex assumes the value of window.location.pathname on a job page would always start with /job. This is untrue for various setups, esp. when jenkins is behind a reverse proxy of nginx/apachehttpd/etc., so the value of window.location.pathname can be /ci/job, or even nested: /apps/ci/job. failing to detect we're on a job page results in missing "Build Now" button.
I'm suggesting this regex: return path.match(/^\/(.*\/)?job\/.*?\//), it allows the above paths, but probably could use some finer-tuning.

[kevinburke]

sounds good! Want to submit a PR

On Wednesday, January 20, 2016, Max Kovgan [email protected] wrote:

NOTE: this is 1 of 2 issues causing these bugs #86
#86 and #73
#73

A regex used in several isJob_() methods does: return
path.match(/^/job/.?//) !== null;, or similar.
This regex assumes the value of window.location.pathname on a job page
would always start with /job. This is untrue for various setups, esp.
when jenkins is behind a reverse proxy of nginx/apachehttpd/etc., so the
value of window.location.pathname can be /ci/job, or even nested:
/apps/ci/job. failing to detect we're on a job page results in missing
"Build Now" button.
I'm suggesting this regex: return path.match(/^/(./)?job/._?//), it
allows the above paths, but probably could use some finer-tuning.

—
Reply to this email directly or view it on GitHub
#91.

Kevin Burke
925.271.7005 | kev.inburke.com

[kevinburke]

The compile process for this project is kind of a nightmare just make the
change and I can do the rest

On Wednesday, January 20, 2016, Kevin Burke [email protected] wrote:

sounds good! Want to submit a PR

On Wednesday, January 20, 2016, Max Kovgan <[email protected]
javascript:_e(%7B%7D,'cvml','[email protected]');> wrote:

NOTE: this is 1 of 2 issues causing these bugs #86
#86 and #73
#73

A regex used in several isJob_() methods does: return
path.match(/^/job/.?//) !== null;, or similar.
This regex assumes the value of window.location.pathname on a job page
would always start with /job. This is untrue for various setups, esp.
when jenkins is behind a reverse proxy of nginx/apachehttpd/etc., so the
value of window.location.pathname can be /ci/job, or even nested:
/apps/ci/job. failing to detect we're on a job page results in missing
"Build Now" button.
I'm suggesting this regex: return path.match(/^/(./)?job/._?//), it
allows the above paths, but probably could use some finer-tuning.

—
Reply to this email directly or view it on GitHub
#91.

Kevin Burke
925.271.7005 | kev.inburke.com

Kevin Burke
925.271.7005 | kev.inburke.com

[mvk]

@kevinburke I think I can run make,
Actually this patch should be added after the 2nd one, b/c until the 2nd one is constructing good request - this one will expose the button which doesn't work.