Skip to content

Commit

Permalink
Bugfix: field close tab callback fired twice on mobile. (#167)
Browse files Browse the repository at this point in the history
* Bugfix: field close tab callback fired twice on mobile.

* version bump
  • Loading branch information
kevinchappell authored Jun 16, 2016
1 parent d2cdb04 commit 6163e71
Show file tree
Hide file tree
Showing 22 changed files with 26 additions and 43 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Changelog

- v1.9.33 - Bugfix: field close tab callback fired twice on mobile [#167](https://github.com/kevinchappell/formBuilder/pull/167)
- v1.9.32 - Bugfix: Change validators to run on blur instead of keyup [#164](https://github.com/kevinchappell/formBuilder/pull/164)
- v1.9.31 - Bugfix: Firefox loses reference to textarea [#161](https://github.com/kevinchappell/formBuilder/pull/161)
- v1.9.30 - Bugfix: Block elements missing classNames [#159](https://github.com/kevinchappell/formBuilder/pull/159)
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
formBuilder v1.9.32
formBuilder v1.9.33
===========

[![Join the chat at https://gitter.im/kevinchappell/formBuilder](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/kevinchappell/formBuilder?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
Expand Down
2 changes: 1 addition & 1 deletion bower.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "formBuilder",
"version": "1.9.32",
"version": "1.9.33",
"main": [
"dist/*"
],
Expand Down
2 changes: 1 addition & 1 deletion demo/assets/css/form-builder.css
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*
formBuilder - http://kevinchappell.github.io/formBuilder/
Version: 1.9.32
Version: 1.9.33
Author: Kevin Chappell <[email protected]>
*/
@charset "UTF-8";
Expand Down
2 changes: 1 addition & 1 deletion demo/assets/css/form-builder.min.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion demo/assets/css/form-render.css
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*
formBuilder - http://kevinchappell.github.io/formBuilder/
Version: 1.9.32
Version: 1.9.33
Author: Kevin Chappell <[email protected]>
*/
* {
Expand Down
2 changes: 1 addition & 1 deletion demo/assets/css/form-render.min.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion demo/assets/css/site.min.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 2 additions & 8 deletions demo/assets/js/form-builder.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*
formBuilder - http://kevinchappell.github.io/formBuilder/
Version: 1.9.32
Version: 1.9.33
Author: Kevin Chappell <[email protected]>
*/
'use strict';
Expand Down Expand Up @@ -2158,7 +2158,7 @@ function formBuilderEventsFn() {
});

// toggle fields
$sortableFields.on('click touchstart', '.toggle-form', function (e) {
$sortableFields.on('click touchstart', '.toggle-form, .close-field', function (e) {
e.stopPropagation();
e.preventDefault();
if (e.handled !== true) {
Expand Down Expand Up @@ -2317,12 +2317,6 @@ function formBuilderEventsFn() {
_helpers.updateMultipleSelect();
});

// Attach a callback to close link
$sortableFields.on('click touchstart', '.close-field', function () {
var fieldId = $(this).parents('li.form-field:eq(0)').attr('id');
_helpers.toggleEdit(fieldId);
});

$sortableFields.on('mouseover mouseout', '.remove, .del-button', function () {
$(this).parents('li:eq(0)').toggleClass('delete');
});
Expand Down
4 changes: 2 additions & 2 deletions demo/assets/js/form-builder.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion demo/assets/js/form-render.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*
formBuilder - http://kevinchappell.github.io/formBuilder/
Version: 1.9.32
Version: 1.9.33
Author: Kevin Chappell <[email protected]>
*/
'use strict';
Expand Down
Loading

0 comments on commit 6163e71

Please sign in to comment.