Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(labels): html in xml labels breaks forms (#858)
Browse files Browse the repository at this point in the history
disabledHTMLLabels option is now set when option.dataType is === 'xml'

BREAKING CHANGE:

Existing forms created using xml dataType that have html labels will have their labels converted to text

Note: the next major release will drop xml support completely
kevinchappell authored Nov 7, 2018

Verified

This commit was signed with the committer’s verified signature.
pradyunsg Pradyun Gedam
1 parent ecedc2e commit 832b1f6
Showing 7 changed files with 10 additions and 9 deletions.
4 changes: 2 additions & 2 deletions assets/js/demo.min.js

Large diffs are not rendered by default.

Binary file modified assets/js/demo.min.js.gz
Binary file not shown.
6 changes: 3 additions & 3 deletions assets/js/form-builder.min.js

Large diffs are not rendered by default.

Binary file modified assets/js/form-builder.min.js.gz
Binary file not shown.
6 changes: 3 additions & 3 deletions assets/js/form-render.min.js

Large diffs are not rendered by default.

Binary file modified assets/js/form-render.min.js.gz
Binary file not shown.
3 changes: 2 additions & 1 deletion index.html
Original file line number Diff line number Diff line change
@@ -9,7 +9,8 @@
</head>

<body>
<label for="toggleBootstrap">Toggle Bootstrap <input type="checkbox" id="toggleBootstrap" /></label>
<label for="toggleBootstrap">Toggle Bootstrap <input type="checkbox" id="toggleBootstrap" /></label> |
dataType: <label>XML <input type="radio" name="demo-dataType" value="xml" class="demo-dataType" /></label><label>JSON <input type="radio" name="demo-dataType" value="json" class="demo-dataType" /></label>
<div class="content">
<h1 class="formbuilder-title">jQuery formBuilder -
<button class="editForm">Render</button>

0 comments on commit 832b1f6

Please sign in to comment.