Skip to content

Commit

Permalink
Bugfix: block elements attributes missing (#159)
Browse files Browse the repository at this point in the history
* Bugfix: block elements attributes missing, Resolves #158

* version bump
  • Loading branch information
kevinchappell committed Jun 2, 2016
1 parent c3a268a commit a56baf8
Show file tree
Hide file tree
Showing 17 changed files with 23 additions and 21 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Changelog

- v1.9.3 - Bugfix: Block elements missing classNames [#159](https://github.com/kevinchappell/formBuilder/pull/159)
- v1.9.28 - Bugfix: Remove polyfills causing problems in some apps [#151](https://github.com/kevinchappell/formBuilder/pull/151)
- v1.9.27 - Bugfix: Header subtypes [#136](https://github.com/kevinchappell/formBuilder/pull/136)
- v1.9.26 - Bugfix: saved subtypes not rendering [#134](https://github.com/kevinchappell/formBuilder/pull/134)
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
formBuilder v1.9.28
formBuilder v1.9.3
===========

[![Join the chat at https://gitter.im/kevinchappell/formBuilder](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/kevinchappell/formBuilder?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
Expand Down
2 changes: 1 addition & 1 deletion bower.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "formBuilder",
"version": "1.9.28",
"version": "1.9.3",
"main": [
"dist/*"
],
Expand Down
3 changes: 1 addition & 2 deletions demo/assets/css/form-builder.css
Original file line number Diff line number Diff line change
Expand Up @@ -907,8 +907,7 @@ ol.sortable-options {
width: 100%;
height: 100%; }

.kc-toggle
.kct-on {
.kc-toggle .kct-on {
color: #12a912; }

.kct-off {
Expand Down
5 changes: 3 additions & 2 deletions demo/assets/js/form-builder.js
Original file line number Diff line number Diff line change
Expand Up @@ -587,7 +587,7 @@ function formBuilderHelpersFn(opts, formBuilder) {
var i,
preview = '',
epoch = new Date().getTime();
attrs = Object.assign({}, attrs);
attrs = jQuery.extend({}, attrs);
attrs.type = attrs.subtype || attrs.type;
var toggle = attrs.toggle ? 'toggle' : '';
// attrs = _helpers.escapeAttrs(attrs);
Expand Down Expand Up @@ -644,7 +644,8 @@ function formBuilderHelpersFn(opts, formBuilder) {
preview = '<input class="ui-autocomplete-input ' + attrs.className + '" autocomplete="on">';
break;
default:
preview = '<' + attrs.type + '>' + attrs.label + '</' + attrs.type + '>';
attrsString = _helpers.attrString(attrs);
preview = '<' + attrs.type + ' ' + attrsString + '>' + attrs.label + '</' + attrs.type + '>';
}

return preview;
Expand Down
2 changes: 1 addition & 1 deletion demo/assets/js/form-builder.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion demo/assets/js/form-render.js
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ function FormRenderFn(options, element) {
}
break;
default:
fieldMarkup = '<' + fieldAttrs.type + '>' + fieldLabelText + '</' + fieldAttrs.type + '>';
fieldMarkup = '<' + fieldAttrs.type + ' ' + fieldAttrsString + '>' + fieldLabelVal + '</' + fieldAttrs.type + '>';
}

if (fieldAttrs.type !== 'hidden') {
Expand Down
2 changes: 1 addition & 1 deletion demo/assets/js/form-render.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion demo/assets/js/form-render.min.js.map

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions dist/form-builder.css
Original file line number Diff line number Diff line change
Expand Up @@ -907,8 +907,7 @@ ol.sortable-options {
width: 100%;
height: 100%; }

.kc-toggle
.kct-on {
.kc-toggle .kct-on {
color: #12a912; }

.kct-off {
Expand Down
5 changes: 3 additions & 2 deletions dist/form-builder.js
Original file line number Diff line number Diff line change
Expand Up @@ -587,7 +587,7 @@ function formBuilderHelpersFn(opts, formBuilder) {
var i,
preview = '',
epoch = new Date().getTime();
attrs = Object.assign({}, attrs);
attrs = jQuery.extend({}, attrs);
attrs.type = attrs.subtype || attrs.type;
var toggle = attrs.toggle ? 'toggle' : '';
// attrs = _helpers.escapeAttrs(attrs);
Expand Down Expand Up @@ -644,7 +644,8 @@ function formBuilderHelpersFn(opts, formBuilder) {
preview = '<input class="ui-autocomplete-input ' + attrs.className + '" autocomplete="on">';
break;
default:
preview = '<' + attrs.type + '>' + attrs.label + '</' + attrs.type + '>';
attrsString = _helpers.attrString(attrs);
preview = '<' + attrs.type + ' ' + attrsString + '>' + attrs.label + '</' + attrs.type + '>';
}

return preview;
Expand Down
2 changes: 1 addition & 1 deletion dist/form-builder.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/form-render.js
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ function FormRenderFn(options, element) {
}
break;
default:
fieldMarkup = '<' + fieldAttrs.type + '>' + fieldLabelText + '</' + fieldAttrs.type + '>';
fieldMarkup = '<' + fieldAttrs.type + ' ' + fieldAttrsString + '>' + fieldLabelVal + '</' + fieldAttrs.type + '>';
}

if (fieldAttrs.type !== 'hidden') {
Expand Down
Loading

0 comments on commit a56baf8

Please sign in to comment.