fix: multiple attribute added to select

kevinchappell · Mar 2, 2020 · bb04cd4 · bb04cd4
1 parent 4c5512b
commit bb04cd4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/js/helpers.js b/src/js/helpers.js
@@ -368,7 +368,7 @@ export default class Helpers {
       })
     }
 
-    previewData = trimObj(previewData)
+    previewData = trimObj(previewData, true)
 
     previewData.className = _this.classNames(field, previewData)
 

diff --git a/src/js/utils.js b/src/js/utils.js
@@ -17,8 +17,11 @@ window.fbEditors = {
  * @param  {Object} attrs {attrName: attrValue}
  * @return {Object}       Object trimmed of null or undefined values
  */
-export const trimObj = function(attrs) {
+export const trimObj = function(attrs, removeFalse = false) {
   const xmlRemove = [null, undefined, '']
+  if (removeFalse) {
+    xmlRemove.push(false)
+  }
   for (const attr in attrs) {
     if (xmlRemove.includes(attrs[attr])) {
       delete attrs[attr]
-Original file line number
+Diff line change
@@ Expand Up / @@ -368,7 +368,7 @@ export default class Helpers { @@
           })
         }
-        previewData = trimObj(previewData)
+        previewData = trimObj(previewData, true)
         previewData.className = _this.classNames(field, previewData)
@@ Expand Down @@