Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

form builder and form render not working with internet explorer 11 #1022

Closed
harshalyelpale opened this issue Jan 3, 2020 · 9 comments · Fixed by #1027 or #1195
Closed

form builder and form render not working with internet explorer 11 #1022

harshalyelpale opened this issue Jan 3, 2020 · 9 comments · Fixed by #1027 or #1195
Labels

Comments

@harshalyelpale
Copy link

harshalyelpale commented Jan 3, 2020

Description:

App Env. : Angular 8 with .Net Core 3.0
form builder and form render not working with internet explorer 11, even edge browser also.
Tried with polyfill.js also, below is script added at the top of other JS files

<script src="https://polyfill.io/v3/polyfill.min.js?features=Object.assign,Object.entries,Promise,Array.prototype.includes,Array.prototype.find,String.prototype.startsWith,Object.values,String.prototype.includes"></script>

formBuilderPolyfillUse

Environment Details:

  • formBuilder Version:
  • Browser: IE 11 & Edge
  • OS: Windows 7, Windows 10

Expected Behavior: It should work (Form Builder & Form Render)

Actual Behavior: Nothing is happening. Not even getting any error in the browser console. However, it works well with Chrome, Firefox browser etc.

Steps to Reproduce

Screenshot - (optional)

@W1-PopelierE
Copy link

W1-PopelierE commented Jan 3, 2020

This is the error:

{description: "Unspecified error.", message: "Unspecified error.", number: -2147467259, stack: "Error: Unspecified error. at t.orderFields (https://formbuilder.online/assets/js/form-builder.min.js:19:102944) at t.appendControls (https://formbuilder.online/assets/js/form-builder.min.js:19:103526) at t.init (https://formbuilder.online/assets/js/form-builder.min.js:19:101748) at e (https://formbuilder.online/assets/js/form-builder.min.js:19:101543) at A (https://formbuilder.online/assets/js/form-builder.min.js:19:104228) at Anonymous function (https://formbuilder.online/assets/js/form-builder.min.js:19:126310) at each (https://cdnjs.cloudflare.com/ajax/libs/jquery/2.1.4/jquery.min.js:2:2875) at n.prototype.each (https://cdnjs.cloudflare.com/ajax/libs/jquery/2.1.4/jquery.min.js:2:838) at Anonymous function (https://formbuilder.online/assets/js/form-builder.min.js:19:126290)"}

When running the project in a node project it works in Edge (https://formbuilder.online/docs/contributing/).

-- edit
Still does not mean this shouldn't be fixed.

kevinchappell added a commit that referenced this issue Jan 26, 2020
@kevinchappell
Copy link
Owner

can you share your configuration in a codepen?
@W1-PopelierE can you test #1027 in IE11?

@W1-PopelierE
Copy link

can you share your configuration in a codepen?
@W1-PopelierE can you test #1027 in IE11?

Will test this when I get home from work.

@W1-PopelierE
Copy link

W1-PopelierE commented Jan 28, 2020

@kevinchappell in IE11 i get these errors:
image

Polyfills (cdn provided by @harshalyelpale ) also couldn't solve it.

--edit

"Internet Explorer is no longer a browser anyone should rely on" ~https://www.theverge.com/2019/2/8/18216767/microsoft-internet-explorer-warning-compatibility-solution

That being mentioned, Edge works fine and the new released Edge Chromium works perfect.
So should supporting Internet Explorer be a goal or a time waste?

@harshalyelpale
Copy link
Author

formBuilder is working perfectly on Microsoft Edge (Chromium-based Edge) Version 79.0.309.71 now. As @W1-PopelierE said Internet Explorer 11 is no longer supported on Windows 7, we should not rely on IE 11.

@kevinchappell
Copy link
Owner

Thanks for testing @W1-PopelierE

@kevinchappell
Copy link
Owner

Resolved by #1033

kevinchappell added a commit that referenced this issue Mar 2, 2020
@kevinchappell
Copy link
Owner

🎉 This issue has been resolved in version 3.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kevinchappell
Copy link
Owner

🎉 This issue has been resolved in version 3.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants