-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Every other call to setData appends data to existing stage contents, instead of overwriting existing data, and causes stage to blank. #1197
Labels
Comments
thanks for opening this issue. I should have a fix out shortly. |
kevinchappell
added a commit
that referenced
this issue
Jun 4, 2021
kevinchappell
added a commit
that referenced
this issue
Jun 4, 2021
Thanks for looking at that, most appreciated, I'm a big fan of your work :) Presumably that fix will be rolled out in the next release? Any idea of your schedule on that? |
github-actions bot
pushed a commit
that referenced
this issue
Jun 4, 2021
## [3.7.1](v3.7.0...v3.7.1) (2021-06-04) ### Bug Fixes * setData working intermittently ([753280f](753280f)), closes [#1197](#1197)
🎉 This issue has been resolved in version 3.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@shaunhurley |
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description:
Hopefully I'm not going mad! While an initial call to actions.setData() works exactly as expected, a second call to actions.setData appends the new data to the existing stage data, and causes the stage to blank (although the data appears to be in place and retreivable via getData())
Further calls to setData alternate between working as expected, and displaying the problem behavior i.e. every odd call works, and every even call appends data/blanks the stage.
Since the calls to setData are being invoked from a manual button press, I can't see how there is any background async behavior possibly causing the issue.
Issuing an actions.clearFields() prior to the actions.setData() does not appear to impact the problem.
Environment Details:
Expected Behavior
Calling setData with a field definition set should overwrite the current data on the stage every time.
Actual Behavior
Calling setData with a field definition set only overwrites the current data on the stage every other time.
Steps to Reproduce
I forked Kevin's original Actions -> SetData codepen to demonstrate what I am seeing @ https://codepen.io/shaunhurley/pen/RwpjWbp
Screenshot - (optional)
The text was updated successfully, but these errors were encountered: