Refactor CSS to fix various namespace clashes and improve compatibility with newer Bootstrap CSS libraries #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cing the scss into an included file under the respective container
…aced css selectors under .form-wrap.form-builder. Consolidate two definitions for .toggle-form.
…aced css selectors under .rendered-form
…d Bootstrap 3 classes while allow the formBuilder styles to be included. This was done by move the embedded Bootstrap 3 classes under an enabling parent class '.formbuilder-embedded-bootstrap'. This class is set by default by both formRender and formBuilder, it can be removed by setting `disableInjectedStyle` to 'bootstrap'. This allows for including Bootstrap CSS libraries directly into the page via stylesheets and not have any clashes with the embedded version which is especially important when trying to work with Bootstrap 4 and 5.
|
🎉 This PR is included in version 3.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FormBuilder has an embedded Bootstrap 3 stylesheet which can cause clashes with HTML elements outside of the formBuilder and formRender containers.
This PR does some refactoring of the style and introduces a modification to an option flag to selectively disable Bootstrap 3 styles into the form.
Refactoring: Move classes under the .rendered-form and .form-wrap.form-builder containers. This ensures we are only setting styles for Elements within our container.
Fixes #594
Fixes #727
Refactoring: Tooltips styles de-duplicated and moved under their own includable scss file to share between form-render and form-builder
Feat: By moving the embedding of Bootstrap 3 styles under an enabling class .formbuilder-embedded-bootstrap we can selectively disable those styles by removing that class. This can be done by setting
disableInjectedStyleto'bootstrap', effectively changingdisableInjectedStylefrom a boolean to a boolean|string option. As disableInjectedStyle defaults to false, the Bootstrap classes will be embeddedTesting has shown no oddities on either Builder nor Render.