Added Laravel 7 support #14
Conversation
kitloong
commented
Mar 9, 2020
kitloong
commented
- Added Laravel 7 support
- AlertDispatcher accept Throwable|Exception https://laravel.com/docs/7.x/upgrade#symfony-5-related-upgrades
| @@ -9,6 +9,7 @@ | |||
| use Kevincobain2000\LaravelAlertNotifications\MicrosoftTeams\Teams; | |||
| use Kevincobain2000\LaravelAlertNotifications\Slack\ExceptionOccurredPayload; | |||
| use Kevincobain2000\LaravelAlertNotifications\Slack\Slack; | |||
| use Throwable; | |||
There was a problem hiding this comment.
if this is just used in @param for the phpdoc, it is better to remove unwanted use or change the phpdoc settings
src/Dispatcher/AlertDispatcher.php
Outdated
| public function __construct( | ||
| Exception $exception, | ||
| $exception, |
There was a problem hiding this comment.
Is there any issue with just using Throwable here? Exception implements the interface since PHP 7, which is the minimum supported PHP version for this package. If that's changed, I'd remove the phpdoc as it doesn't add much value. All of the variables are already type hinted and there's no description provided in the phpdoc for each of the variables.
There was a problem hiding this comment.
Thank you for your review.
Yes Throwable is better. Throwable should working fine in previous Laravel 5 & 6 too
I also updated readme accordingly and vup to 5.0
There was a problem hiding this comment.
Thanks I ll merge and push after @ikari7789 's approval
