Fix composer.json #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitloong
reviewed
Dec 22, 2020
composer.json
Outdated
| }, | ||
| "require-dev": { | ||
| "phpunit/phpunit": "^6.0", | ||
| "phpunit/phpunit": "^8.0", |
There was a problem hiding this comment.
Use
"phpunit/phpunit": "^6.0|^7.0|^8.0",
ikari7789
requested changes
Dec 22, 2020
composer.json
Outdated
| @@ -13,11 +13,11 @@ | |||
| "minimum-stability": "stable", | |||
| "require": { | |||
| "php": ">=7.0.0", | |||
| "guzzlehttp/guzzle": "^6.3", | |||
| "illuminate/support": "~5.0|~6.0|~7.0" | |||
| "guzzlehttp/guzzle": ">=6.3", | |||
There was a problem hiding this comment.
It's still better to define this as ^6.3|^7.0 against the specific versions as otherwise it would automatically accept Guzzle 8.0 if it ever is released and could end up breaking this version.
ikari7789
approved these changes
Dec 22, 2020
View name should user the package prefix so it can be loaded directly from the package without having to publish into the project itself if the consumer doesn't want to. https://laravel.com/docs/5.0/packages#views
…nstead of returning empty string. Use FlattenException to print all nested stack traces
…::mail' to 'vendor.laravel_alert_notifications.mail', for dynamic email template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to use in Laravel8, guzzlehttp/guzzle version should be ^7.0.1.