Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/laravel10 #37

Merged
merged 4 commits into from
Feb 16, 2023
Merged

Feature/laravel10 #37

merged 4 commits into from
Feb 16, 2023

Conversation

kitloong
Copy link
Collaborator

No description provided.

ikari7789
ikari7789 reviewed Feb 16, 2023
View reviewed changes
phpunit.xml Outdated
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" backupGlobals="false" bootstrap="vendor/autoload.php" colors="true" processIsolation="false" stopOnFailure="false" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.0/phpunit.xsd" cacheDirectory=".phpunit.cache" backupStaticProperties="false">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reasoning behind changing the formatting on this?

Copy link
Collaborator Author

@kitloong kitloong Feb 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autogenerated with

./vendor/bin/phpunit --migrate-configuration

Sorry for being lazy, will push the better readable format

@ikari7789
Copy link
Collaborator

@kevincobain2000 changes more or less seem fine. But the GHE Actions only cover L7.x + PHP 7.2 but composer dependencies go back to L5.0 and PHP 7.0. Maybe fine at this point to start dropping older Laravel and PHP versions?

@kevincobain2000
Copy link
Owner

Thanks @kitloong
I ll merge this and it won't hurt to get rid of old versions in new pull reqs.

@kevincobain2000 kevincobain2000 merged commit 640e1fc into master Feb 16, 2023
@kevincobain2000 kevincobain2000 deleted the feature/laravel10 branch February 16, 2023 08:20
@kevincobain2000 kevincobain2000 mentioned this pull request Feb 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikari7789 ikari7789 ikari7789 left review comments

@kevincobain2000 kevincobain2000 Awaiting requested review from kevincobain2000

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kitloong @ikari7789 @kevincobain2000