Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Search Entire Commit Message on Demand; fixes #337 #498

Merged
merged 4 commits into from
Jul 16, 2023

Conversation

kevinmatthes
Copy link
Owner

This PR fixes #337.

@kevinmatthes kevinmatthes added the enhancement New feature or request label Jul 16, 2023
@kevinmatthes kevinmatthes added this to the v4.0.0 milestone Jul 16, 2023
@kevinmatthes kevinmatthes self-assigned this Jul 16, 2023
@github-actions
Copy link
Contributor

Filename                               Stmts    Miss  Cover    Missing
-----------------------------------  -------  ------  -------  ---------------------------------------
src/changelog/comment_changes.rs         156     156  0.00%    102-384
src/changelog/fragment.rs                 56      35  37.50%   100-162
src/changelog/ronlog.rs                  120      72  40.00%   48-239
src/application.rs                        42      42  0.00%    100-172
src/cffreference.rs                       72       0  100.00%
src/increment_version.rs                  90      19  78.89%   123-124, 130-137, 150-155, 216, 231-240
src/macros.rs                             17       0  100.00%
src/running.rs                             4       0  100.00%
src/version.rs                            47       0  100.00%
src/pattern/buffer.rs                     21       0  100.00%
src/pattern/io_processor.rs               17      17  0.00%    72-155
src/pattern/writer.rs                     75      30  60.00%   133-152, 187-197, 229-257
src/traits/append_as_line.rs               9       0  100.00%
src/traits/colour_message.rs               8       0  100.00%
src/traits/convert_buffer.rs              21       0  100.00%
src/traits/prefer.rs                       3       0  100.00%
src/traits/read_file.rs                   30      19  36.67%   54-55, 69-70, 78-94, 105-115
src/traits/rusty_object_notation.rs        8       0  100.00%
src/traits/to_stderr.rs                    4       0  100.00%
src/graphing/agd.rs                      156       0  100.00%
src/graphing/graph.rs                    146       0  100.00%
TOTAL                                   1102     390  64.61%

Copy link
Owner Author

@kevinmatthes kevinmatthes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AmmarAbouZor

Just for completeness, I commented the most important aspects of my solution. In general, it matches your feature request exactly -- except for the renamed trigger option. I will release these changes within the next two days.

src/changelog/comment_changes.rs Show resolved Hide resolved
src/changelog/comment_changes.rs Show resolved Hide resolved
@kevinmatthes kevinmatthes enabled auto-merge (squash) July 16, 2023 17:59
@kevinmatthes kevinmatthes merged commit fb4c948 into main Jul 16, 2023
@kevinmatthes kevinmatthes deleted the feature/337-2 branch July 16, 2023 18:00
@AmmarAbouZor
Copy link

@kevinmatthes
This looks great very thanks for implementing it 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] comment-changes: Check comments both body and summary for keywords
2 participants