fs: don't alter user provided options object

This patch makes a copy of the `options` object before the fs module functions alter it. PR-URL: nodejs/node#7831 Fixes: nodejs/node#7655 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Nicu Micleușanu <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
kevinoid · Dec 13, 2016 · 94a5f53 · 94a5f53
1 parent 0455848
commit 94a5f53
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/fs-file-sync-fd.js b/fs-file-sync-fd.js
@@ -38,6 +38,13 @@ function getOptions(options, defaultOptions) {
   return options;
 }
 
+function copyObject(source, target) {
+  target = arguments.length >= 2 ? target : {};
+  for (const key in source)
+    target[key] = source[key];
+  return target;
+}
+
 function assertEncoding(encoding) {
   if (encoding && !Buffer.isEncoding(encoding)) {
     throw new Error('Unknown encoding: ' + encoding);
@@ -165,11 +172,11 @@ fsFileSyncFD.writeFileSync = function(path, data, options) {
 fsFileSyncFD.appendFileSync = function(path, data, options) {
   options = getOptions(options, { encoding: 'utf8', mode: 438, flag: 'a' });
 
-  if (!options.flag)
-    options = util._extend({ flag: 'a' }, options);
+  // Don't make changes directly on options object
+  options = copyObject(options);
 
   // force append behavior when using a supplied file descriptor
-  if (isFd(path))
+  if (!options.flag || isFd(path))
     options.flag = 'a';
 
   fsFileSyncFD.writeFileSync(path, data, options);