-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt the converter to the changed reco - vtx relations in EDM4hep #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
force-pushed
the
vtx-reco-relations
branch
from
July 12, 2024 08:30
56bcb83
to
257baba
Compare
2 tasks
tmadlener
changed the title
[WIP] Adapt the converter to the changed reco - vtx relations in EDM4hep
Adapt the converter to the changed reco - vtx relations in EDM4hep
Jul 16, 2024
tmadlener
force-pushed
the
vtx-reco-relations
branch
from
July 18, 2024 09:06
257baba
to
3b6ceee
Compare
Tests should be passing again now at least for the basics of roundtripping. Subtle issues are most likely still lurking somewhere and not all things are fully tested yet for these relations. |
Introducing two different maps for looking up reconstructed particles in order to be able to differentiate between ones that are part of the current conversion cycle and the ones that are not
The complete stack now builds locally and this can be merged simultaneously with the changes in EDM4hep. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
Vertex
andReconstructedParticle
to follow the new relation schema introduce in key4hep/EDM4hep#332. NOTE: This is not yet 100 % debugged and tested, due to the inherent complexities of getting both conventions to work simultaneously and together. Please report any issues that you observe.ENDRELEASENOTES
Assumptions that are used in the tests:
ReconstructedParticle
s in LCIO will have attachedparticles
IFF they are anassociatedParticle
of a vertex