Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt the converter to the changed reco - vtx relations in EDM4hep #82

Merged
merged 16 commits into from
Jul 19, 2024

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Jul 11, 2024

BEGINRELEASENOTES

  • Adapt the conversion of Vertex and ReconstructedParticle to follow the new relation schema introduce in key4hep/EDM4hep#332. NOTE: This is not yet 100 % debugged and tested, due to the inherent complexities of getting both conventions to work simultaneously and together. Please report any issues that you observe.

ENDRELEASENOTES

Assumptions that are used in the tests:

  • ReconstructedParticles in LCIO will have attached particles IFF they are an associatedParticle of a vertex
  • For a truly consistent conversion ReconstructedParticles and Vertices have to be converted in one "cycle", i.e. only if all of the objects that were converted are still mutable. Due to mutability constraints we are not able (or we don't want to) update information on objects that are available for lookups and information retrieval, but that have been converted previously and are now to be considered immutable.

@tmadlener tmadlener force-pushed the vtx-reco-relations branch from 56bcb83 to 257baba Compare July 12, 2024 08:30
@tmadlener tmadlener changed the title [WIP] Adapt the converter to the changed reco - vtx relations in EDM4hep Adapt the converter to the changed reco - vtx relations in EDM4hep Jul 16, 2024
@tmadlener tmadlener force-pushed the vtx-reco-relations branch from 257baba to 3b6ceee Compare July 18, 2024 09:06
@tmadlener
Copy link
Contributor Author

Tests should be passing again now at least for the basics of roundtripping. Subtle issues are most likely still lurking somewhere and not all things are fully tested yet for these relations.

Introducing two different maps for looking up reconstructed particles in
order to be able to differentiate between ones that are part of the
current conversion cycle and the ones that are not
@tmadlener
Copy link
Contributor Author

The complete stack now builds locally and this can be merged simultaneously with the changes in EDM4hep.

@tmadlener tmadlener merged commit 73793ab into key4hep:main Jul 19, 2024
1 of 6 checks passed
@tmadlener tmadlener deleted the vtx-reco-relations branch July 19, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant