Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing overlaps in ALLEGRO Ecal barrel geometry #308

Merged
merged 2 commits into from
Jan 9, 2024
Merged

fixing overlaps in ALLEGRO Ecal barrel geometry #308

merged 2 commits into from
Jan 9, 2024

Conversation

faltovaj
Copy link
Contributor

@faltovaj faltovaj commented Dec 7, 2023

BEGINRELEASENOTES

  • fixing the overlaps in ALLEGRO Ecal barrel geometry by increasing the LAr bath volume.
    ENDRELEASENOTES

@BrieucF
Copy link
Contributor

BrieucF commented Dec 11, 2023

Thanks Jana. Can you add one line explaining this change here? Does this fix all overlaps?

@faltovaj
Copy link
Contributor Author

Dear Brieuc, sure I will. Just to be sure: Do the lines go in the section ECalBarrel_NobleLiquid_InclinedTrapezoids - o1_v02?

@BrieucF
Copy link
Contributor

BrieucF commented Dec 11, 2023

Dear Brieuc, sure I will. Just to be sure: Do the lines go in the section ECalBarrel_NobleLiquid_InclinedTrapezoids - o1_v02?

Yes, o1_v02 section indeed

@BrieucF
Copy link
Contributor

BrieucF commented Dec 12, 2023

I ran the overlap check and saw no overlap left, thanks again Jana!

@BrieucF BrieucF merged commit 39a7e4f into key4hep:main Jan 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrieucF BrieucF BrieucF approved these changes

@atolosadelgado atolosadelgado Awaiting requested review from atolosadelgado

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faltovaj @BrieucF