Improve check for a header file from DD4hep #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this check avoids compilation error when old versions of the stack are used, I would prefer keeping that check... The code was actually introduced by @andresailer , what do you think? |
|
As long as we don't require a DD4hep version that includes this file we shouldn't drop the check. We can't check for DDRec because the file was introduced long after DDRec |
jmcarcell
force-pushed
the
ddrec-check
branch
from
b2dbf4a to
45ed4c3
Compare
|
Indeed, now this checks on the version of DD4hep where that header was introduced and if it doesn't exist it will not build the file. |
jmcarcell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES
Also CMake hangs for a while on that check, maybe it's checking a lot of paths. Since DDRec is in the defaults and always built in the stack, I think it's fine not to check for this or if needed to check for DDRec. Eventually the list of files that depend on this header file will be wrong.