Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Default material to CLD o4 v5 material file #422

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

atolosadelgado
Copy link
Collaborator

This solves #421

BEGINRELEASENOTES

  • Add Default material to CLD o4 v5 material file, so it can be used with CAD models.
  • Add simulation test of 1 event for CLD o4 v5

ENDRELEASENOTES

@jmcarcell
Copy link
Member

What happens if there is no default material defined?

@atolosadelgado
Copy link
Collaborator Author

What happens if there is no default material defined?

DDCad requires a material named "Default material" to work, even if it is not used. In our case, it prevents the CAD-based MDI description to be used by CLD.

@jmcarcell jmcarcell enabled auto-merge (squash) January 24, 2025 10:17
@jmcarcell jmcarcell merged commit 0a49f40 into key4hep:main Jan 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants