-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add -Wno-dangling-reference when using GCC #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcarcell
added a commit
to key4hep/EDM4hep
that referenced
this pull request
Sep 24, 2024
jmcarcell
added a commit
to key4hep/k4Clue
that referenced
this pull request
Sep 24, 2024
jmcarcell
added a commit
to key4hep/k4EDM4hep2LcioConv
that referenced
this pull request
Sep 24, 2024
jmcarcell
added a commit
to key4hep/k4FWCore
that referenced
this pull request
Sep 24, 2024
jmcarcell
added a commit
to key4hep/k4geo
that referenced
this pull request
Sep 24, 2024
jmcarcell
added a commit
to key4hep/k4MarlinWrapper
that referenced
this pull request
Sep 24, 2024
jmcarcell
added a commit
to key4hep/k4SimDelphes
that referenced
this pull request
Sep 24, 2024
jmcarcell
added a commit
to key4hep/k4ActsTracking
that referenced
this pull request
Sep 24, 2024
jmcarcell
added a commit
to key4hep/k4-project-template
that referenced
this pull request
Sep 24, 2024
jmcarcell
added a commit
to key4hep/k4Reco
that referenced
this pull request
Sep 24, 2024
jmcarcell
added a commit
to key4hep/k4RecTracker
that referenced
this pull request
Sep 24, 2024
jmcarcell
added a commit
to key4hep/k4GaudiPandora
that referenced
this pull request
Sep 24, 2024
Victor-Schwan
pushed a commit
to Victor-Schwan/k4geo
that referenced
this pull request
Sep 25, 2024
Victor-Schwan
pushed a commit
to Victor-Schwan/k4geo
that referenced
this pull request
Oct 15, 2024
forthommel
pushed a commit
to forthommel/k4ActsTracking
that referenced
this pull request
Nov 14, 2024
AuroraPerego
pushed a commit
to AuroraPerego/k4Clue
that referenced
this pull request
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the inclusion of GCC 14 in the stack, some warnings have appeared when calling some functions in DD4hep that return const &. From what I understand, in these cases this warning is a false positive because the compiler doesn't have access to the implementation of the functions so it can't know there isn't a dangling reference to a temporary (after all the warning only says "possibly"). I suggest removing it. There is also a way of suppressing the warnings in DD4hep with attributes, but then all the affected functions would need it and that can be easily overlooked after adding or changing one while also making the code uglier. This is one example of the warning:
Since this is breaking CI in some places (because of
-Werror
), I'll merge and push the changes soon if there aren't any complains.