Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use crazymax/xgo:1.18.1 docker image as base #17

Merged
merged 2 commits into from
Nov 9, 2022

Conversation

jakubgs
Copy link
Contributor

@jakubgs jakubgs commented Nov 9, 2022

The old xgo image does not work:

# github.com/ethereum/go-ethereum/common
../../../../pkg/mod/github.com/ethereum/[email protected]/common/test_utils.go:27:18: undefined: os.ReadFile
note: module requires Go 1.17
Makefile:31: recipe for target 'test' failed

Appears to work: https://ci.status.im/job/status-keycard/job/keycard-cli/153/

Otherwise the `$HOME` variable is not set which results in:
```
+ make test
go test -v ./...
failed to initialize build cache at /.cache/go-build: mkdir /.cache: permission denied
Makefile:31: recipe for target 'test' failed
```

Signed-off-by: Jakub Sokołowski <[email protected]>
@jakubgs jakubgs self-assigned this Nov 9, 2022
The old `xgo` image does not work:
```
../../../../pkg/mod/github.com/ethereum/[email protected]/common/test_utils.go:27:18: undefined: os.ReadFile
note: module requires Go 1.17
Makefile:31: recipe for target 'test' failed
```

Signed-off-by: Jakub Sokołowski <[email protected]>
@jakubgs jakubgs force-pushed the ci/upgrade-docker-image branch from fbb38dc to c9a28e9 Compare November 9, 2022 18:09
@bitgamma bitgamma merged commit 691380d into develop Nov 9, 2022
@jakubgs jakubgs deleted the ci/upgrade-docker-image branch November 9, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants