Skip to content

Commit

Permalink
Fix links in release notes for 23 (#434)
Browse files Browse the repository at this point in the history
Signed-off-by: stianst <[email protected]>
  • Loading branch information
stianst authored Nov 24, 2023
1 parent f2fca47 commit bb16851
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 13 deletions.
4 changes: 2 additions & 2 deletions cache/releases/23.0.0/gh-release-notes.html
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ <h4 id="_saml_wildfly_and_jboss_eap">SAML WildFly and JBoss EAP</h4>
making it easier and more seamless to install.</p>
</div>
<div class="paragraph">
<p>See the <a href="https://www.keycloak.org/docs/DEV/securing_apps/">Securing Applications and Services Guide</a> for the details.</p>
<p>See the <a href="https://www.keycloak.org/docs/23.0.0/securing_apps/">Securing Applications and Services Guide</a> for the details.</p>
</div>
</div>
</div>
Expand All @@ -135,7 +135,7 @@ <h3 id="_user_profile">User profile</h3>
<div class="paragraph">
<p>Declarative user profile is still a preview feature in this release, but we are working hard on promoting it to a supported feature. Feedback is welcome.
If you find any issues or have any improvements in mind, you are welcome to create <a href="https://github.com/keycloak/keycloak/issues/new/choose">Github issue</a>,
ideally with the label <code>area/user-profile</code>. It is also recommended to check the <a href="https://www.keycloak.org/docs/DEV/upgrading/">Upgrading Guide</a> with the migration changes for this
ideally with the label <code>area/user-profile</code>. It is also recommended to check the <a href="https://www.keycloak.org/docs/23.0.0/upgrading/">Upgrading Guide</a> with the migration changes for this
release for some additional informations related to the migration.</p>
</div>
</div>
Expand Down
4 changes: 2 additions & 2 deletions cache/releases/23.0.0/release-notes.html
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ <h4 id="_saml_wildfly_and_jboss_eap">SAML WildFly and JBoss EAP</h4>
making it easier and more seamless to install.</p>
</div>
<div class="paragraph">
<p>See the <a href="https://www.keycloak.org/docs/DEV/securing_apps/">Securing Applications and Services Guide</a> for the details.</p>
<p>See the <a href="https://www.keycloak.org/docs/23.0.0/securing_apps/">Securing Applications and Services Guide</a> for the details.</p>
</div>
</div>
</div>
Expand All @@ -133,7 +133,7 @@ <h3 id="_user_profile">User profile</h3>
<div class="paragraph">
<p>Declarative user profile is still a preview feature in this release, but we are working hard on promoting it to a supported feature. Feedback is welcome.
If you find any issues or have any improvements in mind, you are welcome to create <a href="https://github.com/keycloak/keycloak/issues/new/choose">Github issue</a>,
ideally with the label <code>area/user-profile</code>. It is also recommended to check the <a href="https://www.keycloak.org/docs/DEV/upgrading/">Upgrading Guide</a> with the migration changes for this
ideally with the label <code>area/user-profile</code>. It is also recommended to check the <a href="https://www.keycloak.org/docs/23.0.0/upgrading/">Upgrading Guide</a> with the migration changes for this
release for some additional informations related to the migration.</p>
</div>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

public class ReleaseNotesBuilder extends AbstractBuilder {

private static final String DOCUMENT_ATTRIBUTES_URL = "https://raw.githubusercontent.com/keycloak/keycloak/main/docs/documentation/topics/templates/document-attributes.adoc";
private static final String DOCUMENT_ATTRIBUTES_URL = "https://raw.githubusercontent.com/keycloak/keycloak/%s/docs/documentation/topics/templates/document-attributes.adoc";

private static final String RELEASE_NOTES_URL = "https://raw.githubusercontent.com/keycloak/keycloak/release/%s/docs/documentation/release_notes/topics/%s.adoc";

Expand All @@ -21,14 +21,6 @@ protected String getTitle() {
}

public void build() throws IOException {
Map<String, Object> attributes = new HashMap<>();

attributes.put("project_buildType", "latest");
attributes.put("leveloffset", "2");
attributes.put("fragment", "yes");

attributes = context.asciiDoctor().parseAttributes(new URL(DOCUMENT_ATTRIBUTES_URL), attributes);

File releasesCache = new File(context.getCacheDir(), "releases");

for (Versions.Version v : context.versions()) {
Expand All @@ -44,6 +36,14 @@ public void build() throws IOException {
} else if (releaseNotesMissingFile.isFile()) {
printStep("missing", v.getVersion());
} else {
Map<String, Object> attributes = new HashMap<>();

attributes.put("project_buildType", "latest");
attributes.put("leveloffset", "2");
attributes.put("fragment", "yes");

attributes = context.asciiDoctor().parseAttributes(new URL(String.format(DOCUMENT_ATTRIBUTES_URL, v.getVersion())), attributes);

String releaseNotesUrl = String.format(RELEASE_NOTES_URL, v.getVersionShorter(), v.getVersion().replace(".", "_"));
URL url = new URL(releaseNotesUrl);

Expand Down

0 comments on commit bb16851

Please sign in to comment.