Update repository to Fedora 31 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 5, 2020
|
awesome, thanks @dawud , will make sure I review tomorrow or very early next week. |
lukehinds
requested changes
Jan 6, 2020
There was a problem hiding this comment.
This is good PR thanks @dawud
I don't know the podman changes to well, so will trust you on those changes.
One small change you could make for me please. git rm the Vagrantfile and remove the vagrant references from the readme. For this role we want it to be for deploying against a hardware TPM. At the moment with VM's we don't have a HW root of trust (this is related to the require_ek configuration I discussed in the GH issue with you.
dawud
force-pushed
the
feature/f31
branch
4 times, most recently
from
64145dc to
e3457b2
Compare
Changes applied to the repository: - Remove duplicated playbook `site.yml` appears unused, uses obsolete `sudo` syntax and a variable not used anywhere else in the role. Seems safe to drop the file - Cosmetic changes to README.md Moved to GitHub flavoured markdown syntax Use language highlighting Break long lines Avoid bare URLs - Drop all references to usage of Vagrant, as this role is meant to be used in real, physical hardware with a TPM Fixes keylime#14 - Remove unneeded comments - Move to new import syntax - Update python requeriments, improve python detection logic - Install dependencies on a single transaction, move dependencies definition to vars - Update Travis test playbook, switch to podman, prefer images from registry.fedoraproject.org - Add simplified Dockerfile for Fedora 30 and 31, where systemd is included, drop Fedora 29 Dockerfile, due to EOL
lukehinds
approved these changes
Jan 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes applied to the repository:
Remove duplicated playbook
site.ymlappears unused, uses obsoletesudosyntax and a variablenot used anywhere else in the role. Seems safe to drop the file
Cosmetic changes to README.md
Moved to GitHub flavoured markdown syntax
Use language highlighting
Break long lines
Avoid bare URLs
Update Vagrantfile to Fedora 31
Fedora 31 is available in Hashicorp's Vagrant Cloud
Use consistent indentation, pin vm_box.version, add ansible compatibility mode
Remove unneeded comments
Move to new import syntax
Update python requeriments, improve python detection logic
Install dependencies on a single transaction, move dependencies
definition to vars
Update Travis test playbook, switch to podman
Add simplified Dockerfile for Fedora 31, where systemd is included