Cargo.lock should not be in gitignore #105
Merged
+1,120
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 29, 2020 15:52
We may need to think of better ways of syncing the conf between both projects. For now I have moved the file over in its entirety as we will require integration tests and so forth (so keys around the verifier and register will be used there).
"If you’re building a non-end product, such as a rust library that other rust packages will depend on, put Cargo.lock in your .gitignore. If you’re building an end product, which are executable like command-line tool or an application, or a system library with crate-type of staticlib or cdylib, check Cargo.lock into git." https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html
ashcrow
approved these changes
Sep 30, 2020
CI failure looks unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"If you’re building a non-end product, such as a rust library that
other rust packages will depend on, put Cargo.lock in your
.gitignore. If you’re building an end product, which are executable
like command-line tool or an application, or a system library with
crate-type of staticlib or cdylib, check Cargo.lock into git."
https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html