Build Error struct and use it #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Uiterwijk <[email protected]>
puiterwijk
force-pushed
the
errorstruct
branch
from
caaa774 to
c166dbe
Compare
lukehinds
reviewed
Oct 8, 2020
| } | ||
|
|
||
| fn response_function(req: Request<Body>) -> BoxFut { | ||
| async fn response_function(req: Request<Body>) -> Result<Response<Body>> { |
There was a problem hiding this comment.
Is there any reason for changing to asynchronous , we historically only used async on the verifier (which is one to many) where as the agent has never been a performance factor (as it only deals serving with one verifier typically or talking to the TPM)
There was a problem hiding this comment.
Yes, because that's technically what you always did with Hyper, it was just hidden behind a Future. I just rebased to Hyper 0.13 as part of this, so the types worked out.
Comment on lines
+39
to
+44
| pub(crate) fn config_get( | ||
| conf_name: &str, | ||
| section: &str, | ||
| key: &str, | ||
| ) -> Result<String> { | ||
| let conf = Ini::load_from_file(conf_name)?; |
lukehinds
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Patrick Uiterwijk [email protected]